heyihong commented on code in PR #44144: URL: https://github.com/apache/spark/pull/44144#discussion_r1413627399
########## python/pyspark/sql/connect/client/core.py: ########## @@ -544,6 +544,25 @@ def fromProto(cls, pb: pb2.ConfigResponse) -> "ConfigResult": ) +class ForbidRecursion: Review Comment: IMO, the logic that determines whether to display stack trace based on SQL Conf should be implemented on the sever side ########## python/pyspark/sql/connect/client/core.py: ########## @@ -544,6 +544,25 @@ def fromProto(cls, pb: pb2.ConfigResponse) -> "ConfigResult": ) +class ForbidRecursion: Review Comment: IMO, the logic that determines whether to display stack trace based on SQL confs should be implemented on the sever side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org