junyuc25 commented on PR #43736: URL: https://github.com/apache/spark/pull/43736#issuecomment-1838922134
> The code looks working. I manually verified `KinesisCheckpointerSuite` and other tests from the CI logs of this PR. > > ``` > 2023-11-20T06:29:03.8869208Z �[0m[�[0m�[0minfo�[0m] �[0m�[0m�[32mKinesisCheckpointerSuite:�[0m�[0m > 2023-11-20T06:29:03.8962864Z �[0m[�[0m�[0minfo�[0m] �[0m�[0m�[32m- checkpoint is not called twice for the same sequence number (4 milliseconds)�[0m�[0m > 2023-11-20T06:29:03.8994512Z �[0m[�[0m�[0minfo�[0m] �[0m�[0m�[32m- checkpoint is called after sequence number increases (2 milliseconds)�[0m�[0m > 2023-11-20T06:29:03.9037111Z �[0m[�[0m�[0minfo�[0m] �[0m�[0m�[32m- should checkpoint if we have exceeded the checkpoint interval (3 milliseconds)�[0m�[0m > 2023-11-20T06:29:03.9061448Z �[0m[�[0m�[0minfo�[0m] �[0m�[0m�[32m- shouldn't checkpoint if we have not exceeded the checkpoint interval (1 millisecond)�[0m�[0m > 2023-11-20T06:29:03.9094827Z �[0m[�[0m�[0minfo�[0m] �[0m�[0m�[32m- should not checkpoint for the same sequence number (1 millisecond)�[0m�[0m > 2023-11-20T06:29:03.9118840Z �[0m[�[0m�[0minfo�[0m] �[0m�[0m�[32m- removing checkpointer checkpoints one last time (1 millisecond)�[0m�[0m > 2 > ``` > > As a next step, please make the PR title and description up-to-date, @junyuc25 . Currently, it's not matched with the AS-IS code. Thanks for the suggestions @dongjoon-hyun. Updated the descriptions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
