ueshin commented on code in PR #44168: URL: https://github.com/apache/spark/pull/44168#discussion_r1414674916
########## python/pyspark/sql/connect/_typing.py: ########## @@ -14,14 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. # -import sys - -if sys.version_info >= (3, 8): - from typing import Protocol, Tuple -else: - from typing_extensions import Protocol - -from typing import Tuple +from typing import Protocol, Tuple Review Comment: Shall we put/merge these in line 19? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
