LuciferYang commented on code in PR #44173: URL: https://github.com/apache/spark/pull/44173#discussion_r1414999619
########## core/src/main/scala/org/apache/spark/deploy/master/RecoveryModeFactory.scala: ########## @@ -67,6 +67,25 @@ private[master] class FileSystemRecoveryModeFactory(conf: SparkConf, serializer: } } +/** + * LeaderAgent in this case is a no-op. Since leader is forever leader as the actual + * recovery is made by restoring from RocksDB. + */ +private[master] class RocksDBRecoveryModeFactory(conf: SparkConf, serializer: Serializer) + extends StandaloneRecoveryModeFactory(conf, serializer) with Logging { + + val recoveryDir = conf.get(RECOVERY_DIRECTORY) Review Comment: From this perspective, I think reusing the configuration is also fine. But, I have another question: If the user first uses `FILESYSTEM` and then switches to `ROCKSDB`, if the user does not clean up `/opt/master` manually, will the residual data in the `/opt/master` directory cause the master to fail to start In this scenario? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org