hvanhovell commented on code in PR #44162:
URL: https://github.com/apache/spark/pull/44162#discussion_r1416044264
##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -2835,29 +2835,12 @@ class Dataset[T] private[sql](
require(colNames.size == cols.size,
s"The size of column names: ${colNames.size} isn't equal to " +
s"the size of columns: ${cols.size}")
- SchemaUtils.checkColumnNameDuplication(
- colNames,
- sparkSession.sessionState.conf.caseSensitiveAnalysis)
-
- val resolver = sparkSession.sessionState.analyzer.resolver
- val output = queryExecution.analyzed.output
-
- val columnSeq = colNames.zip(cols)
-
- val replacedAndExistingColumns = output.map { field =>
- columnSeq.find { case (colName, _) =>
- resolver(field.name, colName)
- } match {
- case Some((colName: String, col: Column)) => col.as(colName)
- case _ => Column(field)
+ withPlan {
+ val aliases = cols.zip(colNames).map {
+ case (column, name) => Alias(column.expr, name)()
}
+ UnresolvedWithColumns(aliases, logicalPlan)
Review Comment:
@cloud-fan I have updated he implementation.
##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -2835,29 +2835,12 @@ class Dataset[T] private[sql](
require(colNames.size == cols.size,
s"The size of column names: ${colNames.size} isn't equal to " +
s"the size of columns: ${cols.size}")
- SchemaUtils.checkColumnNameDuplication(
- colNames,
- sparkSession.sessionState.conf.caseSensitiveAnalysis)
-
- val resolver = sparkSession.sessionState.analyzer.resolver
- val output = queryExecution.analyzed.output
-
- val columnSeq = colNames.zip(cols)
-
- val replacedAndExistingColumns = output.map { field =>
- columnSeq.find { case (colName, _) =>
- resolver(field.name, colName)
- } match {
- case Some((colName: String, col: Column)) => col.as(colName)
- case _ => Column(field)
+ withPlan {
+ val aliases = cols.zip(colNames).map {
+ case (column, name) => Alias(column.expr, name)()
}
+ UnresolvedWithColumns(aliases, logicalPlan)
Review Comment:
@cloud-fan I have updated the 'old' implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
