itholic commented on code in PR #44221: URL: https://github.com/apache/spark/pull/44221#discussion_r1418159477
########## python/docs/source/getting_started/install.rst: ########## @@ -161,6 +161,7 @@ Package Supported version Note `numpy` >=1.21 Required for pandas API on Spark and MLLib DataFrame-based API; Optional for Spark SQL `grpcio` >=1.59.3 Required for Spark Connect `grpcio-status` >=1.59.3 Required for Spark Connect +`protobuf` ==4.25.1 Required for Spark Connect Review Comment: I see. Then what about just removing the protobuf from `dev/requirements.txt` as well to avoid confusion?? As you mentioned seems like `grpcio` and `grpcio-status` automatically detect the specific version and install it when even it's not specified in `dev/requirements.txt` as below: <img width="276" alt="Screenshot 2023-12-07 at 9 32 06 AM" src="https://github.com/apache/spark/assets/44108233/8ee5916b-7c48-4004-954f-0ffbd78b5e9b";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
