HyukjinKwon opened a new pull request, #44226:
URL: https://github.com/apache/spark/pull/44226

   ### What changes were proposed in this pull request?
   
   This PR adds tests for catalog error cases for `createExternalTable`.
   
   Also, this PR includes several minor cleanups:
   - Show a deprecation for `spark.catalog.createExternalTable` (to match with 
the non-Spark Connect)
   - Remove `_reset` at `Catalog` which is not used anywhere.
   - Switch the implementation of Spark Connect 
`spark.catalog.createExternalTable` to directly call 
`spark.catalog.createTable`, and remove the corresponding Python protobuf 
definition.
     - this PR does not remove the protobuf message definition itself for 
potential compatibility concern.
   
   ### Why are the changes needed?
   
   To improve the test coverage.
   
   See 
https://app.codecov.io/gh/apache/spark/commit/1a651753f4e760643d719add3b16acd311454c76/blob/python/pyspark/sql/catalog.py
   
   This is not being tested.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, test-only
   
   ### How was this patch tested?
   
   Manually ran the new unittest.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to