rangadi commented on code in PR #44214:
URL: https://github.com/apache/spark/pull/44214#discussion_r1419486979
##########
connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/ProtobufDataToCatalyst.scala:
##########
@@ -87,22 +79,9 @@ private[sql] case class ProtobufDataToCatalyst(
mode
}
- @transient private lazy val nullResultRow: Any = dataType match {
Review Comment:
@LuciferYang, @justaparth moving the discussion about backward compatibility
to this comment so that we have a nice thread. I agree with concerns. We have
three options to handle this:
* (A) Do not include option to have old behavior (this PR, **preferred**
by author).
* I think 99.99 % of the cases this is will be either not relevant
(because of mode is not set), or does not matter.
* For the remaining cases I think users will understand and update the
query.
* (B) Provide an option to switch to old behavior. The default is new
behavior (**less preferred**).
* I am ok to to do this option, though I don't think it will be used
much.
* We will have a deprecation warning and will remove this option and
relevant code in next major release.
* (C) Keep old behavior as the default and provide option for new behavior
(**least preferred**).
* I do not think this is a good option.
* It makes it hard for users to benefit from the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
