beliefer commented on code in PR #44184: URL: https://github.com/apache/spark/pull/44184#discussion_r1420337431
########## sql/core/src/test/resources/sql-tests/results/group-by.sql.out: ########## @@ -1152,16 +1152,15 @@ SELECT mode(col, 'true') FROM VALUES (-10), (0), (10) AS tab(col) -- !query schema struct<> -- !query output -org.apache.spark.sql.catalyst.ExtendedAnalysisException +org.apache.spark.sql.AnalysisException { - "errorClass" : "DATATYPE_MISMATCH.UNEXPECTED_INPUT_TYPE", - "sqlState" : "42K09", + "errorClass" : "WRONG_NUM_ARGS.WITHOUT_SUGGESTION", Review Comment: Yes. If we need keep compatibility with origin `deterministicExpr`, I will restore them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org