pan3793 commented on code in PR #44211:
URL: https://github.com/apache/spark/pull/44211#discussion_r1420397903
##########
connector/kinesis-asl/pom.xml:
##########
@@ -54,14 +54,38 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>com.amazonaws</groupId>
+ <groupId>software.amazon.kinesis</groupId>
<artifactId>amazon-kinesis-client</artifactId>
Review Comment:
Could you please clarify the relationship between
[software.amazon.kinesis:amazon-kinesis-client](https://mvnrepository.com/artifact/software.amazon.kinesis/amazon-kinesis-client)
and
[software.amazon.awssdk:kinesis](https://mvnrepository.com/artifact/software.amazon.awssdk/kinesis)?
Seems they don't share the version, and the latter is hygienic (no
third-party dependencies other than `software.amazon.awssdk:*`)
Handling Jackson/Guava/Protobuf dependencies conflict is always painful, is
it possible to provide a similar hygienic artifact for the former to make the
downstream project easier to consume?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
