srielau commented on code in PR #44314: URL: https://github.com/apache/spark/pull/44314#discussion_r1424416253
########## sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala: ########## @@ -2638,10 +2638,14 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark test("SPARK-20164: ExtendedAnalysisException should be tolerant to null query plan") { try { - throw new ExtendedAnalysisException("", None, None, plan = null) + throw new ExtendedAnalysisException( + new AnalysisException( + errorClass = "_LEGACY_ERROR_USER_RAISED_EXCEPTION", Review Comment: This error class is meant as a fallback for raise_error(). Why do you pick it here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org