cloud-fan commented on code in PR #44190: URL: https://github.com/apache/spark/pull/44190#discussion_r1424659710
########## sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2Suite.scala: ########## @@ -725,8 +725,127 @@ class DataSourceV2Suite extends QueryTest with SharedSparkSession with AdaptiveS } } + test("SPARK-46272: create table as select") { + val cls = classOf[WritableDataSourceSupportsExternalMetadata] + withTable("test") { + sql( + s""" + |CREATE TABLE test USING ${cls.getName} + |AS VALUES (0, 1), (1, 2) t(i, j) + |""".stripMargin) + checkAnswer(sql("SELECT * FROM test"), Seq((0, 1), (1, 2)).toDF("i", "j")) + sql( + s""" + |CREATE OR REPLACE TABLE test USING ${cls.getName} + |AS VALUES (2, 3), (4, 5) t(i, j) + |""".stripMargin) + checkAnswer(sql("SELECT * FROM test"), Seq((2, 3), (4, 5)).toDF("i", "j")) + sql( + s""" + |CREATE TABLE IF NOT EXISTS test USING ${cls.getName} + |AS VALUES (3, 4), (4, 5) + |""".stripMargin) + checkAnswer(sql("SELECT * FROM test"), Seq((2, 3), (4, 5)).toDF("i", "j")) + } + } + + test("SPARK-46272: create table as select - schema name mismatch") { Review Comment: can we have create table test (no as select) for schema mismatch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org