cloud-fan commented on PR #44187: URL: https://github.com/apache/spark/pull/44187#issuecomment-1853219614
Hi @beliefer , thanks for your time to clean up the Spark codebase! However, I have a bit of concern about this kind of invasive changes. The new API is good and we should definitely use them when writing code. But do we really need to rewrite the old code? Java has a good reputation for backward compatibility, and these old code won't stop us from upgrading to new Java versions. It does bring troubles when a PR touches these files and needs to backport. I think it's not worth our time to rewrite the old code, unless it blocks us from upgrading Scala/Java. I think a simple principle is to not touch the old code if they are working well and not deprecated. Is the old `instanceof` syntax deprecated in new Java versions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
