mridulm commented on code in PR #44264:
URL: https://github.com/apache/spark/pull/44264#discussion_r1424867167
##########
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java:
##########
@@ -391,13 +391,16 @@ private static TrustManager[] defaultTrustManagers(File
trustStore, String trust
}
}
- private static KeyManager[] keyManagers(File keyStore, String
keyStorePassword)
+ private static KeyManager[] keyManagers(
+ File keyStore, String keyPassword, String keyStorePassword)
throws NoSuchAlgorithmException, CertificateException,
KeyStoreException, IOException, UnrecoverableKeyException {
KeyManagerFactory factory = KeyManagerFactory.getInstance(
KeyManagerFactory.getDefaultAlgorithm());
- char[] passwordCharacters = keyStorePassword != null?
keyStorePassword.toCharArray() : null;
- factory.init(loadKeyStore(keyStore, passwordCharacters),
passwordCharacters);
+ char[] keyStorePasswordChars = keyStorePassword != null?
keyStorePassword.toCharArray() : null;
+ char[] keyPasswordChars = keyPassword != null?
Review Comment:
super nit:
```suggestion
char[] keyStorePasswordChars = keyStorePassword != null ?
keyStorePassword.toCharArray() : null;
char[] keyPasswordChars = keyPassword != null ?
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
