LuciferYang commented on code in PR #44327:
URL: https://github.com/apache/spark/pull/44327#discussion_r1424881010
##########
common/network-common/src/main/java/org/apache/spark/network/util/RocksDBProvider.java:
##########
@@ -100,7 +100,11 @@ public static RocksDB initRockDB(File dbFile, StoreVersion
version, ObjectMapper
// is unusable
checkVersion(tmpDb, version, mapper);
} catch (RocksDBException e) {
+ tmpDb.close();
throw new IOException(e.getMessage(), e);
+ } catch (IOException ioe) {
+ tmpDb.close();
+ throw ioe;
Review Comment:
https://github.com/apache/spark/blob/83434af22284482d4e805d8be625f733b074928b/common/network-common/src/main/java/org/apache/spark/network/util/RocksDBProvider.java#L151-L152
For RocksDB, it may throw either RocksDBException or IOException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
