LuciferYang commented on code in PR #44347:
URL: https://github.com/apache/spark/pull/44347#discussion_r1426180105
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -809,7 +809,7 @@ public MergeStatuses
finalizeShuffleMerge(FinalizeShuffleMerge msg) {
msg.shuffleMergeId, partition.reduceId);
// This can throw IOException which will marks this shuffle
partition as not merged.
partition.finalizePartition();
- if (partition.mapTracker.getCardinality() > 0) {
+ if (!partition.mapTracker.isEmpty()) {
Review Comment:
There should only be this one place where `getCardinality() > 0` is used for
empty-checking on `RoaringBitmap `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
