panbingkun commented on code in PR #44208:
URL: https://github.com/apache/spark/pull/44208#discussion_r1427454717
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:
##########
@@ -66,6 +66,13 @@ class HiveExternalCatalogVersionsSuite extends
SparkSubmitTestUtils {
.map(new File(_)).getOrElse(Utils.createTempDir(namePrefix =
"test-spark"))
private val unusedJar = TestUtils.createJarWithClasses(Seq.empty)
val hiveVersion = HiveUtils.builtinHiveVersion
+ private val skipReleaseVersions =
+ sys.env.getOrElse("SKIP_SPARK_RELEASE_VERSIONS", "").split(",").toSet
+ // scalastyle:off println
Review Comment:
Only for GA test.
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:
##########
@@ -212,45 +219,54 @@ class HiveExternalCatalogVersionsSuite extends
SparkSubmitTestUtils {
}
PROCESS_TABLES.testingVersions.zipWithIndex.foreach { case (version,
index) =>
- val sparkHome = new File(sparkTestingDir, s"spark-$version")
- if (!sparkHome.exists()) {
- tryDownloadSpark(version, sparkTestingDir.getCanonicalPath)
+ // scalastyle:off println
Review Comment:
Only for GA test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
