JoshRosen commented on code in PR #44321:
URL: https://github.com/apache/spark/pull/44321#discussion_r1428630112
##########
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala:
##########
@@ -787,6 +787,8 @@ private[spark] class TaskSetManager(
// SPARK-37300: when the task was already finished state, just ignore it,
// so that there won't cause successful and tasksSuccessful wrong result.
Review Comment:
I think this branch is handling a rare corner-case where the same
`TaskSetManager` can mark the same task as both succeeded but failed. There is
some detailed prior discussion of this in
https://issues.apache.org/jira/browse/SPARK-37300
##########
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala:
##########
@@ -787,6 +787,8 @@ private[spark] class TaskSetManager(
// SPARK-37300: when the task was already finished state, just ignore it,
// so that there won't cause successful and tasksSuccessful wrong result.
Review Comment:
I think this branch is handling a rare corner-case where the same
`TaskSetManager` can mark the same task as both succeeded and failed. There is
some detailed prior discussion of this in
https://issues.apache.org/jira/browse/SPARK-37300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
