dbatomic commented on code in PR #44316:
URL: https://github.com/apache/spark/pull/44316#discussion_r1431241503
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveInlineTables.scala:
##########
@@ -105,26 +107,40 @@ object ResolveInlineTables extends Rule[LogicalPlan]
val attributes = DataTypeUtils.toAttributes(StructType(fields))
assert(fields.size == table.names.size)
- val newRows: Seq[InternalRow] = table.rows.map { row =>
- InternalRow.fromSeq(row.zipWithIndex.map { case (e, ci) =>
- val targetType = fields(ci).dataType
- try {
+ val castedRows: Seq[Seq[Expression]] = table.rows.map { row =>
+ row.zipWithIndex.map {
+ case (e, ci) =>
+ val targetType = fields(ci).dataType
val castedExpr = if (DataTypeUtils.sameType(e.dataType, targetType))
{
e
} else {
cast(e, targetType)
}
- prepareForEval(castedExpr).eval()
- } catch {
- case NonFatal(ex) =>
- table.failAnalysis(
- errorClass =
"INVALID_INLINE_TABLE.FAILED_SQL_EXPRESSION_EVALUATION",
- messageParameters = Map("sqlExpr" -> toSQLExpr(e)),
- cause = ex)
- }
- })
+ castedExpr
+ }
}
- LocalRelation(attributes, newRows)
+ val noCurrentLike: Boolean =
castedRows.flatten.forall(!_.containsPattern(CURRENT_LIKE))
+ if (noCurrentLike) {
+ val evalRows: Seq[InternalRow] =
Review Comment:
Yep, good idea. I also organized code a bit better and made it more testable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
