LuciferYang commented on code in PR #44477:
URL: https://github.com/apache/spark/pull/44477#discussion_r1436089675
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:
##########
@@ -211,6 +213,10 @@ class HiveExternalCatalogVersionsSuite extends
SparkSubmitTestUtils {
tryDownloadSpark(version, sparkTestingDir.getCanonicalPath)
}
+ Files.deleteIfExists(Paths.get(sparkHome.getCanonicalPath, "jars",
"ivy-2.5.1.jar"))
+ val ivyUrl = new
URL("https://repo1.maven.org/maven2/org/apache/ivy/ivy/2.5.2/ivy-2.5.2.jar";)
+ IOUtils.copy(ivyUrl, new File(s"${sparkHome.getCanonicalPath}/jars",
"ivy-2.5.2.jar"))
Review Comment:
I have been investigating the case of the previous Ivy upgrade failure
recently. I found that if the Spark version being tested in
`HiveExternalCatalogVersionsSuite` also uses Ivy 2.5.2, the error like
https://github.com/apache/spark/pull/44477#issuecomment-1868917258 will not
occur again... But I haven't come up with a better solution yet.
cc @bjornjorgensen @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
