MaxGekk commented on code in PR #44503: URL: https://github.com/apache/spark/pull/44503#discussion_r1437008913
########## common/utils/src/main/resources/error/error-classes.json: ########## @@ -1480,12 +1474,6 @@ }, "sqlState" : "42K0B" }, - "INCORRECT_END_OFFSET" : { Review Comment: For some reasons there is still a reference to the error class: ``` $ find . -type f -print0|xargs -0 grep INCORRECT_END_OFFSET ./docs/sql-error-conditions-sqlstates.md: <td><a href="arithmetic-overflow-error-class.md">ARITHMETIC_OVERFLOW</a>, <a href="sql-error-conditions.html#cast_overflow">CAST_OVERFLOW</a>, <a href="sql-error-conditions.html#cast_overflow_in_table_insert">CAST_OVERFLOW_IN_TABLE_INSERT</a>, <a href="sql-error-conditions.html#decimal_precision_exceeds_max_precision">DECIMAL_PRECISION_EXCEEDS_MAX_PRECISION</a>, <a href="sql-error-conditions.html#invalid_index_of_zero">INVALID_INDEX_OF_ZERO</a>, <a href="sql-error-conditions.html#incorrect_end_offset">INCORRECT_END_OFFSET</a>, <a href="sql-error-conditions.html#incorrect_ramp_up_rate">INCORRECT_RAMP_UP_RATE</a>, <a href="invalid-array-index-error-class.md">INVALID_ARRAY_INDEX</a>, <a href="invalid-array-index-in-element-at-error-class.md">INVALID_ARRAY_INDEX_IN_ELEMENT_AT</a>, <a href="sql-error-conditions.html#numeric_out_of_supported_range">NUMERIC_OUT_OF_SUPPORTED_RANGE</a>, <a href="sql-error-conditions.html#numeric_value_out_of_range ">NUMERIC_VALUE_OUT_OF_RANGE</a> ``` ########## sql/api/src/main/scala/org/apache/spark/sql/errors/DataTypeErrors.scala: ########## @@ -27,7 +27,7 @@ import org.apache.spark.unsafe.types.UTF8String /** * Object for grouping error messages from (most) exceptions thrown during query execution. * This does not include exceptions thrown during the eager execution of commands, which are - * grouped into [[QueryCompilationErrors]]. Review Comment: ok, let's leave the ref to `CompilationErrors` only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org