heyihong commented on code in PR #44464:
URL: https://github.com/apache/spark/pull/44464#discussion_r1438179268
##########
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala:
##########
@@ -230,55 +230,75 @@ private[client] object GrpcExceptionConverter {
params.cause)),
errorConstructor(params =>
new NoSuchTableException(params.errorClass.orNull,
params.messageParameters, params.cause)),
- errorConstructor[NumberFormatException](params =>
+ errorConstructor(params =>
new SparkNumberFormatException(
- params.message,
- params.errorClass,
+ params.errorClass.orNull,
params.messageParameters,
params.queryContext)),
+ errorConstructor[NumberFormatException](params =>
+ new SparkNumberFormatException(
+ errorClass = "_LEGACY_ERROR_TEMP_3104",
+ messageParameters = Map("message" -> params.message),
+ params.queryContext)),
+ errorConstructor(params =>
+ new SparkIllegalArgumentException(
+ params.errorClass.orNull,
+ params.messageParameters,
+ params.queryContext,
+ cause = params.cause.orNull)),
errorConstructor[IllegalArgumentException](params =>
new SparkIllegalArgumentException(
- params.message,
- params.cause,
- params.errorClass,
+ errorClass = "_LEGACY_ERROR_TEMP_3105",
+ messageParameters = Map("message" -> params.message),
+ params.queryContext,
+ cause = params.cause.orNull)),
+ errorConstructor(params =>
+ new SparkArithmeticException(
+ params.errorClass.orNull,
params.messageParameters,
params.queryContext)),
errorConstructor[ArithmeticException](params =>
new SparkArithmeticException(
- params.message,
- params.errorClass,
- params.messageParameters,
+ errorClass = "_LEGACY_ERROR_TEMP_3106",
+ messageParameters = Map("message" -> params.message),
params.queryContext)),
+ errorConstructor(params =>
+ new SparkUnsupportedOperationException(params.errorClass.orNull,
params.messageParameters)),
errorConstructor[UnsupportedOperationException](params =>
new SparkUnsupportedOperationException(
- params.message,
- params.errorClass,
- params.messageParameters)),
+ errorClass = "_LEGACY_ERROR_TEMP_3107",
+ messageParameters = Map("message" -> params.message))),
+ errorConstructor(params =>
+ new SparkArrayIndexOutOfBoundsException(
+ params.errorClass.orNull,
+ params.messageParameters,
+ params.queryContext)),
errorConstructor[ArrayIndexOutOfBoundsException](params =>
new SparkArrayIndexOutOfBoundsException(
- params.message,
- params.errorClass,
+ errorClass = "_LEGACY_ERROR_TEMP_3108",
+ messageParameters = Map("message" -> params.message),
+ params.queryContext)),
+ errorConstructor(params =>
+ new SparkDateTimeException(
+ params.errorClass.orNull,
params.messageParameters,
params.queryContext)),
errorConstructor[DateTimeException](params =>
new SparkDateTimeException(
- params.message,
- params.errorClass,
- params.messageParameters,
+ errorClass = "_LEGACY_ERROR_TEMP_3109",
Review Comment:
ditto
##########
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala:
##########
@@ -230,55 +230,75 @@ private[client] object GrpcExceptionConverter {
params.cause)),
errorConstructor(params =>
new NoSuchTableException(params.errorClass.orNull,
params.messageParameters, params.cause)),
- errorConstructor[NumberFormatException](params =>
+ errorConstructor(params =>
new SparkNumberFormatException(
- params.message,
- params.errorClass,
+ params.errorClass.orNull,
params.messageParameters,
params.queryContext)),
+ errorConstructor[NumberFormatException](params =>
+ new SparkNumberFormatException(
+ errorClass = "_LEGACY_ERROR_TEMP_3104",
+ messageParameters = Map("message" -> params.message),
+ params.queryContext)),
+ errorConstructor(params =>
+ new SparkIllegalArgumentException(
+ params.errorClass.orNull,
+ params.messageParameters,
+ params.queryContext,
+ cause = params.cause.orNull)),
errorConstructor[IllegalArgumentException](params =>
new SparkIllegalArgumentException(
- params.message,
- params.cause,
- params.errorClass,
+ errorClass = "_LEGACY_ERROR_TEMP_3105",
Review Comment:
ditto
##########
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala:
##########
@@ -230,55 +230,75 @@ private[client] object GrpcExceptionConverter {
params.cause)),
errorConstructor(params =>
new NoSuchTableException(params.errorClass.orNull,
params.messageParameters, params.cause)),
- errorConstructor[NumberFormatException](params =>
+ errorConstructor(params =>
new SparkNumberFormatException(
- params.message,
- params.errorClass,
+ params.errorClass.orNull,
params.messageParameters,
params.queryContext)),
+ errorConstructor[NumberFormatException](params =>
+ new SparkNumberFormatException(
+ errorClass = "_LEGACY_ERROR_TEMP_3104",
Review Comment:
Actually, this may need some special handling since params.errorClass and
params.messageParameters may be set
##########
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala:
##########
@@ -230,55 +230,75 @@ private[client] object GrpcExceptionConverter {
params.cause)),
errorConstructor(params =>
new NoSuchTableException(params.errorClass.orNull,
params.messageParameters, params.cause)),
- errorConstructor[NumberFormatException](params =>
+ errorConstructor(params =>
new SparkNumberFormatException(
- params.message,
- params.errorClass,
+ params.errorClass.orNull,
params.messageParameters,
params.queryContext)),
+ errorConstructor[NumberFormatException](params =>
+ new SparkNumberFormatException(
+ errorClass = "_LEGACY_ERROR_TEMP_3104",
+ messageParameters = Map("message" -> params.message),
+ params.queryContext)),
+ errorConstructor(params =>
+ new SparkIllegalArgumentException(
+ params.errorClass.orNull,
+ params.messageParameters,
+ params.queryContext,
+ cause = params.cause.orNull)),
errorConstructor[IllegalArgumentException](params =>
new SparkIllegalArgumentException(
- params.message,
- params.cause,
- params.errorClass,
+ errorClass = "_LEGACY_ERROR_TEMP_3105",
+ messageParameters = Map("message" -> params.message),
+ params.queryContext,
+ cause = params.cause.orNull)),
+ errorConstructor(params =>
+ new SparkArithmeticException(
+ params.errorClass.orNull,
params.messageParameters,
params.queryContext)),
errorConstructor[ArithmeticException](params =>
new SparkArithmeticException(
- params.message,
- params.errorClass,
- params.messageParameters,
+ errorClass = "_LEGACY_ERROR_TEMP_3106",
Review Comment:
ditto
##########
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala:
##########
@@ -230,55 +230,75 @@ private[client] object GrpcExceptionConverter {
params.cause)),
errorConstructor(params =>
new NoSuchTableException(params.errorClass.orNull,
params.messageParameters, params.cause)),
- errorConstructor[NumberFormatException](params =>
+ errorConstructor(params =>
new SparkNumberFormatException(
- params.message,
- params.errorClass,
+ params.errorClass.orNull,
params.messageParameters,
params.queryContext)),
+ errorConstructor[NumberFormatException](params =>
+ new SparkNumberFormatException(
+ errorClass = "_LEGACY_ERROR_TEMP_3104",
+ messageParameters = Map("message" -> params.message),
+ params.queryContext)),
+ errorConstructor(params =>
+ new SparkIllegalArgumentException(
+ params.errorClass.orNull,
+ params.messageParameters,
+ params.queryContext,
+ cause = params.cause.orNull)),
errorConstructor[IllegalArgumentException](params =>
new SparkIllegalArgumentException(
- params.message,
- params.cause,
- params.errorClass,
+ errorClass = "_LEGACY_ERROR_TEMP_3105",
+ messageParameters = Map("message" -> params.message),
+ params.queryContext,
+ cause = params.cause.orNull)),
+ errorConstructor(params =>
+ new SparkArithmeticException(
+ params.errorClass.orNull,
params.messageParameters,
params.queryContext)),
errorConstructor[ArithmeticException](params =>
new SparkArithmeticException(
- params.message,
- params.errorClass,
- params.messageParameters,
+ errorClass = "_LEGACY_ERROR_TEMP_3106",
+ messageParameters = Map("message" -> params.message),
params.queryContext)),
+ errorConstructor(params =>
+ new SparkUnsupportedOperationException(params.errorClass.orNull,
params.messageParameters)),
errorConstructor[UnsupportedOperationException](params =>
new SparkUnsupportedOperationException(
- params.message,
- params.errorClass,
- params.messageParameters)),
+ errorClass = "_LEGACY_ERROR_TEMP_3107",
Review Comment:
ditto
##########
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala:
##########
@@ -230,55 +230,75 @@ private[client] object GrpcExceptionConverter {
params.cause)),
errorConstructor(params =>
new NoSuchTableException(params.errorClass.orNull,
params.messageParameters, params.cause)),
- errorConstructor[NumberFormatException](params =>
+ errorConstructor(params =>
new SparkNumberFormatException(
- params.message,
- params.errorClass,
+ params.errorClass.orNull,
params.messageParameters,
params.queryContext)),
+ errorConstructor[NumberFormatException](params =>
+ new SparkNumberFormatException(
+ errorClass = "_LEGACY_ERROR_TEMP_3104",
+ messageParameters = Map("message" -> params.message),
+ params.queryContext)),
+ errorConstructor(params =>
+ new SparkIllegalArgumentException(
+ params.errorClass.orNull,
+ params.messageParameters,
+ params.queryContext,
+ cause = params.cause.orNull)),
errorConstructor[IllegalArgumentException](params =>
new SparkIllegalArgumentException(
- params.message,
- params.cause,
- params.errorClass,
+ errorClass = "_LEGACY_ERROR_TEMP_3105",
+ messageParameters = Map("message" -> params.message),
+ params.queryContext,
+ cause = params.cause.orNull)),
+ errorConstructor(params =>
+ new SparkArithmeticException(
+ params.errorClass.orNull,
params.messageParameters,
params.queryContext)),
errorConstructor[ArithmeticException](params =>
new SparkArithmeticException(
- params.message,
- params.errorClass,
- params.messageParameters,
+ errorClass = "_LEGACY_ERROR_TEMP_3106",
+ messageParameters = Map("message" -> params.message),
params.queryContext)),
+ errorConstructor(params =>
+ new SparkUnsupportedOperationException(params.errorClass.orNull,
params.messageParameters)),
errorConstructor[UnsupportedOperationException](params =>
new SparkUnsupportedOperationException(
- params.message,
- params.errorClass,
- params.messageParameters)),
+ errorClass = "_LEGACY_ERROR_TEMP_3107",
+ messageParameters = Map("message" -> params.message))),
+ errorConstructor(params =>
+ new SparkArrayIndexOutOfBoundsException(
+ params.errorClass.orNull,
+ params.messageParameters,
+ params.queryContext)),
errorConstructor[ArrayIndexOutOfBoundsException](params =>
new SparkArrayIndexOutOfBoundsException(
- params.message,
- params.errorClass,
+ errorClass = "_LEGACY_ERROR_TEMP_3108",
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
