beliefer commented on code in PR #44397:
URL: https://github.com/apache/spark/pull/44397#discussion_r1444003277
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##########
@@ -271,6 +279,15 @@ protected String visitAggregateFunction(
}
}
+ protected String visitInverseDistributionFunction(
+ String funcName, boolean isDistinct, String[] inputs, String[]
orderingWithinGroups) {
+ assert(isDistinct == false);
+ String withinGroup =
+ joinArrayToString(orderingWithinGroups, ", ", "WITHIN GROUP (ORDER BY ",
")");
Review Comment:
Please refer `visitSortOrder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
