MaxGekk commented on code in PR #44501:
URL: https://github.com/apache/spark/pull/44501#discussion_r1447444430


##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala:
##########
@@ -713,9 +713,7 @@ class StreamSuite extends StreamTest {
         "columnName" -> "`rn_col`",
         "windowSpec" ->
           ("(PARTITION BY COL1 ORDER BY COL2 ASC NULLS FIRST ROWS BETWEEN 
UNBOUNDED PRECEDING " +
-          "AND CURRENT ROW)")),
-      queryContext = Array(
-        ExpectedContext(fragment = "withColumn", callSitePattern = 
getCurrentClassCallSitePattern)))

Review Comment:
   I have added `origin` from the head expression:
   ```scala
             throw 
QueryExecutionErrors.nonTimeWindowNotSupportedInStreamingError(
               windowFuncList,
               columnNameList,
               windowSpecList,
               windowExpression.head.origin)
   ```
   for double check. In that case, the query context is propagated obviously.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to