nchammas opened a new pull request, #44667:
URL: https://github.com/apache/spark/pull/44667

   ### What changes were proposed in this pull request?
   
   As [promised here][1], this change loosens our Ruby dependency specification 
so that Bundler can update transitive dependencies more easily.
   
   Other changes included:
   - Remove the direct dependency on webrick, because Jekyll [fixed the 
problem][2] that caused us to add it in the first place.
   - Add explanatory comments to parts of the document generation process that 
are not obvious.
   
   [1]: https://github.com/apache/spark/pull/44628#discussion_r1445151689
   [2]: https://github.com/jekyll/jekyll/pull/8524
   
   We can still build our docs using Ruby 2.7, but we should push devs to 
install Ruby 3 since Ruby 2 is [EOL][3] and we are unable to upgrade some of 
our doc dependencies until we're running Ruby 3.
   
   [3]: https://www.ruby-lang.org/en/news/2022/04/12/ruby-2-7-6-released/
   
   ### Why are the changes needed?
   
   Make the document building process more robust to future updates coming from 
the Ruby ecosystem.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   I built and reviewed the docs on both Ruby 2.7.8 and Ruby 3.3.0 using the 
following command:
   
   ```sh
   SKIP_SCALADOC=1 SKIP_PYTHONDOC=1 SKIP_RDOC=1 bundle exec jekyll build
   ```
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to