viirya commented on code in PR #44636: URL: https://github.com/apache/spark/pull/44636#discussion_r1448132991
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/streaming/ReadLimit.java: ########## @@ -39,6 +39,8 @@ static ReadLimit minRows(long rows, long maxTriggerDelayMs) { static ReadLimit maxFiles(int files) { return new ReadMaxFiles(files); } + static ReadLimit maxBytes(int bytes) { return new ReadMaxBytes(bytes); } Review Comment: Good catch. `long` looks more proper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org