tgravescs commented on PR #44852: URL: https://github.com/apache/spark/pull/44852#issuecomment-1908218024
It would be nice to have more description here about what the challenge is (why it just didn't work) and then how you went about solving/fixing it. > Does this PR introduce any user-facing change? > No Is this really true? doesn't this now allow user to call these together? Does it affect spark connect api since you mention that? Please update description as it should be clear to reviewer without looking at the code what the proposed changes are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org