LuciferYang commented on code in PR #45056: URL: https://github.com/apache/spark/pull/45056#discussion_r1481327727
########## connector/connect/common/src/main/scala/org/apache/spark/sql/connect/common/ProtoUtils.scala: ########## @@ -42,7 +42,17 @@ private[connect] object ProtoUtils { val size = string.length val threshold = thresholds.getOrElse(STRING, MAX_STRING_SIZE) if (size > threshold) { - builder.setField(field, createString(string.take(threshold), size)) + builder.setField(field, truncateString(string, threshold)) + } + + case (field: FieldDescriptor, strings: java.lang.Iterable[_]) + if field.getJavaType == FieldDescriptor.JavaType.STRING && field.isRepeated + && strings != null => + val threshold = thresholds.getOrElse(STRING, MAX_STRING_SIZE) + strings.iterator().asScala.zipWithIndex.foreach { + case (string: String, i) if string != null && string.length > threshold => Review Comment: Can `string` really be null? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org