dongjoon-hyun commented on code in PR #45061: URL: https://github.com/apache/spark/pull/45061#discussion_r1482187670
########## resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesVolumeUtils.scala: ########## @@ -105,4 +109,13 @@ private[spark] object KubernetesVolumeUtils { throw new NoSuchElementException(key + s" is required for $msg") } } + + private def verifySize(size: Option[String]): Unit = { + size.foreach { v => + if (v.forall(_.isDigit) && parseLong(v) < 1024) { + throw new IllegalArgumentException( + s"Volume size `$v` is smaller than 1KiB. Missing units?") + } + } Review Comment: Yes, right~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org