LuciferYang commented on code in PR #45015:
URL: https://github.com/apache/spark/pull/45015#discussion_r1482479360
##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala:
##########
@@ -118,7 +119,11 @@ private[sql] class AvroOptions(
* taken into account. If the former one is not set too, the `snappy` codec
is used by default.
*/
val compression: String = {
- parameters.get(COMPRESSION).getOrElse(SQLConf.get.avroCompressionCodec)
+ val v =
parameters.get(COMPRESSION).getOrElse(SQLConf.get.avroCompressionCodec)
+ if (v == null) {
Review Comment:
Would there be compatibility issues if null values are prohibited in
`CaseInsensitiveMap`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
