dongjoon-hyun commented on code in PR #45079:
URL: https://github.com/apache/spark/pull/45079#discussion_r1486497892
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/UISeleniumSuite.scala:
##########
@@ -102,13 +104,13 @@ class UISeleniumSuite extends SparkFunSuite with
WebBrowser {
eventually(timeout(10.seconds), interval(100.milliseconds)) {
val sd = findErrorMessageOnSQLUI()
assert(sd.size === 1, "Analyze fail shall show the query in failed
table")
- assert(sd.head.startsWith("[TABLE_OR_VIEW_NOT_FOUND]"))
+ assert(sd.head.startsWith("TABLE_OR_VIEW_NOT_FOUND"))
val id = findExecutionIDOnSQLUI()
// check query detail page
go to s"${spark.sparkContext.uiWebUrl.get}/SQL/execution/?id=$id"
val planDot = findAll(cssSelector(""".dot-file""")).map(_.text).toList
- assert(planDot.head.startsWith("digraph G {"))
+ assert(planDot.size === 1)
Review Comment:
Yes, we cannot check the test because it's invisible text according to the
HTML spec, @viirya . I verified it manually the following.
- The text is changed and now starting with ` digraph G {` instead of
`digraph G`.
- Since this is an error case check, the graph itself is empty. There is no
meaning to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
