HeartSaVioR commented on PR #45023: URL: https://github.com/apache/spark/pull/45023#issuecomment-1940310614
Given we have a reference PR now, shall we think through better breakdown of PRs? Some of individual PR may not need to have a test (e.g. interface definition) if you are fully ensuring that you have enough test coverage in reference PR. My suggestion would be following: at least interface must be separated out. We should have an extensive review from the interface PR, especially for interface/method contract. After that, you can revisit the remaining and see how you can help reviewers to review with smaller but incremental changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
