viirya commented on code in PR #45096: URL: https://github.com/apache/spark/pull/45096#discussion_r1489864752
########## connector/kinesis-asl-assembly/pom.xml: ########## @@ -59,16 +59,6 @@ <artifactId>commons-lang</artifactId> <scope>provided</scope> </dependency> - <dependency> - <groupId>com.google.protobuf</groupId> - <artifactId>protobuf-java</artifactId> - <version>2.6.1</version> - <!-- - We are being explicit about version here and overriding the - spark default of 2.5.0 because KCL appears to have introduced - a dependency on protobuf 2.6.1 somewhere between KCL 1.4.0 and 1.6.1. - --> - </dependency> Review Comment: Before SPARK-14421, it is a provided dependency. Don't we need to keep it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org