wbo4958 commented on PR #45157: URL: https://github.com/apache/spark/pull/45157#issuecomment-1953312076
Hi @srowen, The public API [def resource(resourceName: String, amount: Double): this.type = {](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/resource/TaskResourceRequests.scala#L71) in TaskResourceRequests require double, and the [TaskResourceRequest](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/resource/TaskResourceRequest.scala#L37) also require double. So if we would like to go from the string, that probably breaks the APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org