itholic commented on code in PR #44881: URL: https://github.com/apache/spark/pull/44881#discussion_r1495314548
########## python/pyspark/pandas/series.py: ########## @@ -7092,15 +7092,15 @@ def resample( ---------- rule : str The offset string or object representing target conversion. - Currently, supported units are {'Y', 'A', 'M', 'D', 'H', - 'T', 'MIN', 'S'}. + Currently, supported units are {'YE', 'A', 'ME', 'D', 'h', + 'min', 'MIN', 's'}. Review Comment: > Even for the users who choose old Pandas libraries, Apache Spark enforces this breaking change Yes. In current policy, if we want to use latest Apache Spark then we cannot avoid having to follow the behavior of latest Pandas as well IIRC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org