cloud-fan commented on code in PR #43751: URL: https://github.com/apache/spark/pull/43751#discussion_r1495320778
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java: ########## @@ -97,6 +102,28 @@ public interface TableCatalog extends CatalogPlugin { */ Identifier[] listTables(String[] namespace) throws NoSuchNamespaceException; + /** + * List the tables in a namespace from the catalog by pattern string. + * <p> + * If the catalog supports views, this must return identifiers for only tables and not views. + * + * @param namespace a multi-part namespace + * @param pattern the filter pattern, only '*' and '|' are allowed as wildcards, others will Review Comment: not related to this PR, but the existing doc is a bit vague. `|` is not a wildcard, right? And `|` is also a valid syntax in regex. Can we take a look at other databases and see how they document it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org