cloud-fan commented on code in PR #45104: URL: https://github.com/apache/spark/pull/45104#discussion_r1495897055
########## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ########## @@ -174,4 +174,36 @@ class CollationSuite extends QueryTest with SharedSparkSession { Row(expected)) } } + + + test("disable partition on collated string column") { + def createTable(partitionColumns: String*): Unit = { + val tableName = "test_partition_tbl" + withTable(tableName) { + sql( + s""" + |CREATE TABLE $tableName Review Comment: can we also test v2 tables? See `DataSourceV2SQLSuite` about how we create and test v2 tables using v2 catalogs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org