mihailom-db commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1497104483
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -3748,6 +3748,12 @@
},
"sqlState" : "0A000"
},
+ "UNSUPPORTED_ENCODER" : {
+ "message" : [
+ "Found unsupported encoder. Try switching to expression encoder."
+ ],
+ "sqlState" : "0A000"
Review Comment:
I have changed the category to `42` as I believe the error is possible to
happen only if a user defines implicit `Encoder` for which an implicit
`Encoder` does not already exist. I experimented with trying to use types `Int`
or `String`, but realised that we already have implicit values defined and in
those cases `.toDS()` call was marked as unresolved and the code did not even
compile. `KryoData` seems to not have an implicit Encoder defined, so the added
test is possible to happen. So I am not sure if I should change error name
and/or message accordingly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
