anishshri-db commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1503733977
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala:
##########
@@ -69,8 +70,20 @@ case class TransformWithStateExec(
override def shortName: String = "transformWithStateExec"
- // TODO: update this to run no-data batches when timer support is added
- override def shouldRunAnotherBatch(newInputWatermark: Long): Boolean = false
+ override def shouldRunAnotherBatch(newInputWatermark: Long): Boolean = {
+ timeoutMode match {
+ // TODO: check if we can return true only if actual timers are registered
Review Comment:
Yea - but the time at which this is called - I believe we don't have the
storeRDD or store instance available directly. We could potentially track some
count, but haven't tried the change/optimization yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
