srowen commented on PR #44690: URL: https://github.com/apache/spark/pull/44690#issuecomment-1966702439
It looks like there are many not-quite-the-same changes related to this JIRA. The change I'm concerned about is in https://github.com/apache/spark/pull/43494 - the whole trying to do floating-point math with a long thing. That does not fix the particular issue that was claimed, it just moves around the issue. It sounds like you're saying there were other issues that are resolved by this change? that's more reasonable if so, but I still am uncomfortable with the change. That said I haven't thought through all the changes attached to this JIRA. The core issue of floating-point inaccuracy doesn't go away, and then I'm not sure why bother with the long, and that complexity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
