liuzqt commented on PR #40812: URL: https://github.com/apache/spark/pull/40812#issuecomment-1968189774
Had a discussion with @maryannxue , a few thoughts: - might not be a good idea to implicitly override innerChildren with clone behavior? it's a generate function from base class, even if it's only used for generateString for now. If we're trying to narrowly fix the explain issue, is it possible to hold a lock on callsite? - apart from explain string, is there any other usage that could be vulnerable to concurrency issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
