wbo4958 commented on PR #44690: URL: https://github.com/apache/spark/pull/44690#issuecomment-1968358962
"simply subtracting 1 ulp" may cause the precision error to be accumulated when doing the double calculation each time, and may finally result in unexpected behavior. Anyway, "simply subtracting 1 ulp" may be another kind of doable way, but just as you said, "It may not be worth pursuing this any further though." So, let's get back to this PR itself, is it ok to be merged into spark 3.5 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
