cosmind-db commented on code in PR #45202:
URL: https://github.com/apache/spark/pull/45202#discussion_r1505540581
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala:
##########
@@ -700,17 +700,19 @@ class ParquetFilters(
makeNotEq.lift(nameToParquetField(name).fieldType)
.map(_(nameToParquetField(name).fieldNames, value))
- case sources.LessThan(name, value) if canMakeFilterOn(name, value) =>
+ case sources.LessThan(name, value) if (value != null) &&
canMakeFilterOn(name, value) =>
Review Comment:
EqualTo and EqualNullSafe translate to Eq in parquet which are null
tolerant.
Eq:
https://github.com/apache/parquet-mr/blob/master/parquet-column/src/main/java/org/apache/parquet/filter2/predicate/Operators.java#L174
Lt:
https://github.com/apache/parquet-mr/blob/master/parquet-column/src/main/java/org/apache/parquet/filter2/predicate/Operators.java#L200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
