HyukjinKwon commented on code in PR #45363: URL: https://github.com/apache/spark/pull/45363#discussion_r1510598001
########## python/pyspark/sql/group.py: ########## @@ -450,6 +446,10 @@ def pivot(self, pivot_col: str, values: Optional[List["LiteralType"]] = None) -> values : list, optional List of values that will be translated to columns in the output DataFrame. + .. note:: If ``values`` is not provided, Spark will **eagerly** compute the distinct Review Comment: this too. I would just put it up in the doctest (like `DataFrameReader.csv`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org