cloud-fan commented on code in PR #45282: URL: https://github.com/apache/spark/pull/45282#discussion_r1510653381
########## sql/core/src/main/scala/org/apache/spark/sql/execution/ExplainUtils.scala: ########## @@ -76,7 +76,7 @@ object ExplainUtils extends AdaptiveSparkPlanHelper { * 1. Generates the explain output for the input plan excluding the subquery plans. * 2. Generates the explain output for each subquery referenced in the plan. */ - def processPlan[T <: QueryPlan[T]](plan: T, append: String => Unit): Unit = { + def processPlan[T <: QueryPlan[T]](plan: T, append: String => Unit): Unit = synchronized { Review Comment: `children` is `def` too, but I don't see we create local variables... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org