yaooqinn commented on code in PR #45357:
URL: https://github.com/apache/spark/pull/45357#discussion_r1512030230
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CoalesceShufflePartitions.scala:
##########
@@ -126,9 +126,12 @@ case class CoalesceShufflePartitions(session:
SparkSession) extends AQEShuffleRe
// data sources may request a particular advisory partition size for the
final write stage
// if it happens, the advisory partition size will be set in
ShuffleQueryStageExec
// only one shuffle stage is expected in such cases
- private def advisoryPartitionSize(shuffleStages: Seq[ShuffleStageInfo]):
Long = {
+ private def advisoryPartitionSize(coalesceGroup: CoalesceGroup): Long = {
+ if (coalesceGroup.hasExplodingJoin) {
+ return conf.getConf(SQLConf.COALESCE_PARTITIONS_MIN_PARTITION_SIZE)
Review Comment:
Maybe we can respect `spark.sql.adaptive.coalescePartitions.parallelismFirst
here`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
