anishshri-db commented on code in PR #45341: URL: https://github.com/apache/spark/pull/45341#discussion_r1513485319
########## sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithMapStateSuite.scala: ########## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.streaming + +import org.apache.spark.SparkException +import org.apache.spark.sql.Encoders +import org.apache.spark.sql.execution.streaming.MemoryStream +import org.apache.spark.sql.execution.streaming.state.RocksDBStateStoreProvider +import org.apache.spark.sql.internal.SQLConf + +case class InputMapRow(key: String, action: String, value: (String, String)) + +class TestMapStateProcessor + extends StatefulProcessor[String, InputMapRow, (String, String, String)] { + + @transient var _processorHandle: StatefulProcessorHandle = _ + @transient var _mapState: MapState[String, String] = _ + + override def init(handle: StatefulProcessorHandle, outputMode: OutputMode): Unit = { + _processorHandle = handle + _mapState = handle.getMapState("sessionState", Encoders.STRING) + } + + override def handleInputRows( + key: String, + inputRows: Iterator[InputMapRow], + timerValues: TimerValues): Iterator[(String, String, String)] = { + + var output = List[(String, String, String)]() + + for (row <- inputRows) { + if (row.action == "exists") { + output = (key, "exists", _mapState.exists().toString) :: output + } else if (row.action == "getValue") { + output = (key, row.value._1, _mapState.getValue(row.value._1)) :: output + } else if (row.action == "containsKey") { + output = (key, row.value._1, + if (_mapState.containsKey(row.value._1)) "true" else "false") :: output + } else if (row.action == "updateValue") { + _mapState.updateValue(row.value._1, row.value._2) + } else if (row.action == "getMap") { + val res = _mapState.getMap() + res.foreach { pair => + output = (key, pair._1, pair._2) :: output + } + } else if (row.action == "getKeys") { + _mapState.getKeys().foreach { key => + output = (row.key, key, row.value._2) :: output + } + } else if (row.action == "getValues") { + _mapState.getValues().foreach { value => + output = (row.key, row.value._1, value) :: output + } + } else if (row.action == "removeKey") { + _mapState.removeKey(row.value._1) + } else if (row.action == "remove") { + _mapState.clear() + } + } + output.iterator + } + + override def close(): Unit = {} +} + +class TransformWithMapStateSuite extends StreamTest { + import testImplicits._ + + private def testMapStateWithNullUserKey(inputMapRow: InputMapRow): Unit = { + withSQLConf(SQLConf.STATE_STORE_PROVIDER_CLASS.key -> + classOf[RocksDBStateStoreProvider].getName) { + + val inputData = MemoryStream[InputMapRow] + val result = inputData.toDS() + .groupByKey(x => x.key) + .transformWithState(new TestMapStateProcessor(), + TimeoutMode.NoTimeouts(), + OutputMode.Update()) + + testStream(result, OutputMode.Update())( + AddData(inputData, inputMapRow), + ExpectFailure[SparkException](e => { + assert(e.getMessage.contains("User key cannot be null")) + }) + ) + } + } + + test("Test retrieving value with non-exist user key") { Review Comment: Nit: `non-existing` or `absent` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
