zhuqi-lucas commented on code in PR #45314: URL: https://github.com/apache/spark/pull/45314#discussion_r1513735868
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/HasPartitionSize.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.read; + +import java.util.OptionalLong; + +/** + * A mix-in for input partitions whose records are clustered on the same set of partition keys + * (provided via {@link SupportsReportPartitioning}, see below). Data sources can opt-in to + * implement this interface for the partitions they report to Spark, which will use the info + * to decide whether partition grouping should be applied or not. + * + * @see org.apache.spark.sql.connector.read.SupportsReportPartitioning + * @since 4.0.0 + */ +public interface HasPartitionSize extends InputPartition { Review Comment: Thank you @sunchao for review, and this is a good suggestion, i check the Iceberg code, it includes the sizeBytes and estimatedRowsCount, filesCount. Let me address this! ``` @Override default long sizeBytes() { return tasks().stream().mapToLong(ScanTask::sizeBytes).sum(); } @Override default long estimatedRowsCount() { return tasks().stream().mapToLong(ScanTask::estimatedRowsCount).sum(); } @Override default int filesCount() { return tasks().stream().mapToInt(ScanTask::filesCount).sum(); } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
