srielau commented on code in PR #45405: URL: https://github.com/apache/spark/pull/45405#discussion_r1514694683
########## python/pyspark/sql/tests/test_types.py: ########## @@ -862,15 +862,13 @@ def test_parse_datatype_string(self): if k != "varchar" and k != "char": self.assertEqual(t(), _parse_datatype_string(k)) self.assertEqual(IntegerType(), _parse_datatype_string("int")) - self.assertEqual(StringType(), _parse_datatype_string("string COLLATE 'UCS_BASIC'")) + self.assertEqual(StringType(), _parse_datatype_string("string COLLATE UCS_BASIC")) self.assertEqual(StringType(0), _parse_datatype_string("string")) - self.assertEqual(StringType(0), _parse_datatype_string("string COLLATE 'UCS_BASIC'")) - self.assertEqual(StringType(0), _parse_datatype_string("string COLLATE 'UCS_BASIC'")) - self.assertEqual(StringType(0), _parse_datatype_string("string COLLATE'UCS_BASIC'")) - self.assertEqual(StringType(1), _parse_datatype_string("string COLLATE 'UCS_BASIC_LCASE'")) - self.assertEqual(StringType(1), _parse_datatype_string("string COLLATE 'UCS_BASIC_LCASE'")) - self.assertEqual(StringType(2), _parse_datatype_string("string COLLATE 'UNICODE'")) - self.assertEqual(StringType(3), _parse_datatype_string("string COLLATE 'UNICODE_CI'")) + self.assertEqual(StringType(0), _parse_datatype_string("string COLLATE UCS_BASIC")) Review Comment: Silly question, isn't this a good time to switch from UCS_BASIC to UTF8_BINARY? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org