zhengruifeng commented on code in PR #45412:
URL: https://github.com/apache/spark/pull/45412#discussion_r1515374917


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3509,6 +3509,17 @@ object SQLConf {
       .booleanConf
       .createWithDefault(true)
 
+  val WRAP_EXISTS_IN_AGGREGATE_FUNCTION =
+    buildConf("spark.sql.optimizer.wrapExistsInAggregateFunction")
+      .internal()
+      .doc("When true, the optimizer will wrap newly introduced `exists` 
attributes in an" +
+      "aggregate function to ensure that Aggregate nodes preserve semantic 
invariant that each" +
+      "variable among agg expressions appears either in grouping expressions 
or belongs to" +

Review Comment:
   nit, missing spaces
   
   ```suggestion
         .doc("When true, the optimizer will wrap newly introduced `exists` 
attributes in an " +
         "aggregate function to ensure that Aggregate nodes preserve semantic 
invariant that each " +
         "variable among agg expressions appears either in grouping expressions 
or belongs to " +
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to